fix: nil-close bug, stale docs, dead code, and tracked binaries #7
15
.gitignore
vendored
15
.gitignore
vendored
@@ -37,18 +37,9 @@ go.work.sum
|
|||||||
# Air artifacts
|
# Air artifacts
|
||||||
*tmp/
|
*tmp/
|
||||||
|
|
||||||
# binaries
|
# Example binaries and data files
|
||||||
internal/examples/chatroom/chatroom
|
internal/examples/*/[a-z]*[!.go]
|
||||||
internal/examples/counter/counter
|
internal/examples/shakespeare/shake.db
|
||||||
internal/examples/countercomp/countercomp
|
|
||||||
internal/examples/greeter/greeter
|
|
||||||
internal/examples/livereload/livereload
|
|
||||||
internal/examples/picocss/picocss
|
|
||||||
internal/examples/plugins/plugins
|
|
||||||
internal/examples/realtimechart/realtimechart
|
|
||||||
internal/examples/shakespeare/shakespeare
|
|
||||||
internal/examples/nats-chatroom/nats-chatroom
|
|
||||||
/nats-chatroom
|
|
||||||
|
|
||||||
# NATS data directory
|
# NATS data directory
|
||||||
data/
|
data/
|
||||||
|
|||||||
@@ -74,14 +74,13 @@ func main() {
|
|||||||
- **Plugin system** — `func(v *V)` hooks for integrating CSS/JS libraries
|
- **Plugin system** — `func(v *V)` hooks for integrating CSS/JS libraries
|
||||||
- **Structured logging** — zerolog with configurable levels; console output in dev, JSON in production
|
- **Structured logging** — zerolog with configurable levels; console output in dev, JSON in production
|
||||||
- **Graceful shutdown** — listens for SIGINT/SIGTERM, drains contexts, closes pub/sub
|
- **Graceful shutdown** — listens for SIGINT/SIGTERM, drains contexts, closes pub/sub
|
||||||
- **Context lifecycle** — background reaper cleans up disconnected contexts; configurable TTL
|
|
||||||
- **HTML DSL** — the `h` package provides type-safe Go-native HTML composition
|
- **HTML DSL** — the `h` package provides type-safe Go-native HTML composition
|
||||||
|
|
||||||
## Examples
|
## Examples
|
||||||
|
|
||||||
The `internal/examples/` directory contains 14 runnable examples:
|
The `internal/examples/` directory contains 19 runnable examples:
|
||||||
|
|
||||||
`chatroom` · `counter` · `countercomp` · `greeter` · `keyboard` · `livereload` · `nats-chatroom` · `pathparams` · `picocss` · `plugins` · `pubsub-crud` · `realtimechart` · `session` · `shakespeare`
|
`chatroom` · `counter` · `countercomp` · `effectspike` · `greeter` · `keyboard` · `livereload` · `maplibre` · `middleware` · `nats-chatroom` · `pathparams` · `picocss` · `plugins` · `pubsub-crud` · `realtimechart` · `session` · `shakespeare` · `signup` · `spa`
|
||||||
|
|
||||||
## Experimental
|
## Experimental
|
||||||
|
|
||||||
|
|||||||
10
ci-check.sh
10
ci-check.sh
@@ -6,9 +6,13 @@ set -o pipefail
|
|||||||
ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
||||||
cd "$ROOT"
|
cd "$ROOT"
|
||||||
|
|
||||||
echo "== CI: Format code =="
|
echo "== CI: Check formatting =="
|
||||||
go fmt ./...
|
if [ -n "$(gofmt -l .)" ]; then
|
||||||
echo "OK: formatting complete"
|
echo "ERROR: files not formatted:"
|
||||||
|
gofmt -l .
|
||||||
|
exit 1
|
||||||
|
fi
|
||||||
|
echo "OK: all files formatted"
|
||||||
|
|
||||||
echo "== CI: Run go vet =="
|
echo "== CI: Run go vet =="
|
||||||
if ! go vet ./...; then
|
if ! go vet ./...; then
|
||||||
|
|||||||
@@ -1,7 +1,6 @@
|
|||||||
package via
|
package via
|
||||||
|
|
||||||
import (
|
import (
|
||||||
"fmt"
|
|
||||||
"strconv"
|
"strconv"
|
||||||
"strings"
|
"strings"
|
||||||
|
|
||||||
@@ -51,5 +50,5 @@ func (s *computedSignal) recompute() {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func (s *computedSignal) patchValue() string {
|
func (s *computedSignal) patchValue() string {
|
||||||
return fmt.Sprintf("%v", s.lastVal)
|
return s.lastVal
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -94,7 +94,7 @@ Available triggers:
|
|||||||
|--------|-------|-------|
|
|--------|-------|-------|
|
||||||
| `OnClick()` | `click` | |
|
| `OnClick()` | `click` | |
|
||||||
| `OnDblClick()` | `dblclick` | |
|
| `OnDblClick()` | `dblclick` | |
|
||||||
| `OnChange()` | `change` | 200ms debounce |
|
| `OnChange()` | `change` | |
|
||||||
| `OnInput()` | `input` | No debounce |
|
| `OnInput()` | `input` | No debounce |
|
||||||
| `OnSubmit()` | `submit` | |
|
| `OnSubmit()` | `submit` | |
|
||||||
| `OnKeyDown(key)` | `keydown` | Filtered by key name (e.g. `"Enter"`, `"Escape"`) |
|
| `OnKeyDown(key)` | `keydown` | Filtered by key name (e.g. `"Enter"`, `"Escape"`) |
|
||||||
|
|||||||
2
h/h.go
2
h/h.go
@@ -5,7 +5,7 @@
|
|||||||
//
|
//
|
||||||
// h.Div(
|
// h.Div(
|
||||||
// h.H1(h.Text("Hello, Via")),
|
// h.H1(h.Text("Hello, Via")),
|
||||||
// h.P(h.Text("Pure Go. No tmplates.")),
|
// h.P(h.Text("Pure Go. No templates.")),
|
||||||
// )
|
// )
|
||||||
package h
|
package h
|
||||||
|
|
||||||
|
|||||||
@@ -2,7 +2,6 @@ package main
|
|||||||
|
|
||||||
import (
|
import (
|
||||||
"github.com/ryanhamamura/via"
|
"github.com/ryanhamamura/via"
|
||||||
// "github.com/go-via/via-plugin-picocss/picocss"
|
|
||||||
"github.com/ryanhamamura/via/h"
|
"github.com/ryanhamamura/via/h"
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -15,9 +14,6 @@ func main() {
|
|||||||
DocumentTitle: "Live Reload Demo",
|
DocumentTitle: "Live Reload Demo",
|
||||||
DevMode: true,
|
DevMode: true,
|
||||||
LogLevel: via.LogLevelDebug,
|
LogLevel: via.LogLevelDebug,
|
||||||
Plugins: []via.Plugin{
|
|
||||||
// picocss.Default
|
|
||||||
},
|
|
||||||
})
|
})
|
||||||
|
|
||||||
v.Page("/", func(c *via.Context) {
|
v.Page("/", func(c *via.Context) {
|
||||||
|
|||||||
@@ -4,17 +4,12 @@ import (
|
|||||||
"strconv"
|
"strconv"
|
||||||
|
|
||||||
"github.com/ryanhamamura/via"
|
"github.com/ryanhamamura/via"
|
||||||
// "github.com/go-via/via-plugin-picocss/picocss"
|
|
||||||
. "github.com/ryanhamamura/via/h"
|
. "github.com/ryanhamamura/via/h"
|
||||||
)
|
)
|
||||||
|
|
||||||
func main() {
|
func main() {
|
||||||
v := via.New()
|
v := via.New()
|
||||||
|
|
||||||
v.Config(via.Options{
|
|
||||||
// Plugins: []via.Plugin{picocss.Default},
|
|
||||||
})
|
|
||||||
|
|
||||||
v.Page("/counters/{counter_id}/{start_at_step}", func(c *via.Context) {
|
v.Page("/counters/{counter_id}/{start_at_step}", func(c *via.Context) {
|
||||||
|
|
||||||
counterID := c.GetPathParam("counter_id")
|
counterID := c.GetPathParam("counter_id")
|
||||||
|
|||||||
Binary file not shown.
@@ -2,7 +2,6 @@ package main
|
|||||||
|
|
||||||
import (
|
import (
|
||||||
"github.com/ryanhamamura/via"
|
"github.com/ryanhamamura/via"
|
||||||
// "github.com/go-via/via-plugin-picocss/picocss"
|
|
||||||
"github.com/ryanhamamura/via/h"
|
"github.com/ryanhamamura/via/h"
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -13,11 +12,6 @@ func main() {
|
|||||||
|
|
||||||
v.Config(via.Options{
|
v.Config(via.Options{
|
||||||
DocumentTitle: "Via Counter",
|
DocumentTitle: "Via Counter",
|
||||||
// Plugin is placed here. Use picocss.WithOptions(pococss.Options) to add the plugin
|
|
||||||
// with a different color theme or to enable a classes for a wide range of colors.
|
|
||||||
// Plugins: []via.Plugin{
|
|
||||||
// picocss.Default,
|
|
||||||
// },
|
|
||||||
})
|
})
|
||||||
|
|
||||||
v.Page("/", func(c *via.Context) {
|
v.Page("/", func(c *via.Context) {
|
||||||
|
|||||||
@@ -6,7 +6,6 @@ import (
|
|||||||
"time"
|
"time"
|
||||||
|
|
||||||
"github.com/ryanhamamura/via"
|
"github.com/ryanhamamura/via"
|
||||||
// "github.com/go-via/via-plugin-picocss/picocss"
|
|
||||||
"github.com/ryanhamamura/via/h"
|
"github.com/ryanhamamura/via/h"
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -16,9 +15,6 @@ func main() {
|
|||||||
v.Config(via.Options{
|
v.Config(via.Options{
|
||||||
LogLevel: via.LogLevelDebug,
|
LogLevel: via.LogLevelDebug,
|
||||||
DevMode: true,
|
DevMode: true,
|
||||||
Plugins: []via.Plugin{
|
|
||||||
// picocss.Default,
|
|
||||||
},
|
|
||||||
})
|
})
|
||||||
|
|
||||||
v.AppendToHead(
|
v.AppendToHead(
|
||||||
|
|||||||
@@ -22,6 +22,9 @@ type ShakeDB struct {
|
|||||||
findByTextStmt *sql.Stmt
|
findByTextStmt *sql.Stmt
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Prepare opens shake.db, a ~22 MB SQLite database of Shakespeare's works.
|
||||||
|
// Download from https://github.com/nicholasgasior/gopher-fizzbuzz/raw/master/shake.db
|
||||||
|
// and place it in this directory before running.
|
||||||
func (shakeDB *ShakeDB) Prepare() {
|
func (shakeDB *ShakeDB) Prepare() {
|
||||||
db, err := sql.Open("sqlite3", "shake.db")
|
db, err := sql.Open("sqlite3", "shake.db")
|
||||||
if err != nil {
|
if err != nil {
|
||||||
|
|||||||
Binary file not shown.
@@ -1,7 +1,6 @@
|
|||||||
package via
|
package via
|
||||||
|
|
||||||
import (
|
import (
|
||||||
// "net/http/httptest"
|
|
||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
"github.com/ryanhamamura/via/h"
|
"github.com/ryanhamamura/via/h"
|
||||||
|
|||||||
65
via.go
65
via.go
@@ -439,36 +439,39 @@ func (v *V) ensureDatastarHandler() {
|
|||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func loadDevModeMap(path string) map[string]string {
|
||||||
|
m := make(map[string]string)
|
||||||
|
file, err := os.Open(path)
|
||||||
|
if err != nil {
|
||||||
|
return m
|
||||||
|
}
|
||||||
|
defer file.Close()
|
||||||
|
json.NewDecoder(file).Decode(&m)
|
||||||
|
return m
|
||||||
|
}
|
||||||
|
|
||||||
|
func saveDevModeMap(path string, m map[string]string) error {
|
||||||
|
file, err := os.Create(path)
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
defer file.Close()
|
||||||
|
return json.NewEncoder(file).Encode(m)
|
||||||
|
}
|
||||||
|
|
||||||
func (v *V) devModePersist(c *Context) {
|
func (v *V) devModePersist(c *Context) {
|
||||||
p := filepath.Join(".via", "devmode", "ctx.json")
|
p := filepath.Join(".via", "devmode", "ctx.json")
|
||||||
if err := os.MkdirAll(filepath.Dir(p), 0755); err != nil {
|
if err := os.MkdirAll(filepath.Dir(p), 0755); err != nil {
|
||||||
v.logFatal("failed to create directory for devmode files: %v", err)
|
v.logFatal("failed to create directory for devmode files: %v", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
// load persisted list from file, or empty list if file not found
|
ctxRegMap := loadDevModeMap(p)
|
||||||
file, err := os.Open(p)
|
|
||||||
ctxRegMap := make(map[string]string)
|
|
||||||
if err == nil {
|
|
||||||
json.NewDecoder(file).Decode(&ctxRegMap)
|
|
||||||
}
|
|
||||||
file.Close()
|
|
||||||
|
|
||||||
// add ctx to persisted list
|
|
||||||
if _, ok := ctxRegMap[c.id]; !ok {
|
if _, ok := ctxRegMap[c.id]; !ok {
|
||||||
ctxRegMap[c.id] = c.route
|
ctxRegMap[c.id] = c.route
|
||||||
}
|
}
|
||||||
|
|
||||||
// write persisted list to file
|
if err := saveDevModeMap(p, ctxRegMap); err != nil {
|
||||||
file, err = os.Create(p)
|
v.logErr(c, "devmode failed to persist ctx: %v", err)
|
||||||
if err != nil {
|
|
||||||
v.logErr(c, "devmode failed to percist ctx: %v", err)
|
|
||||||
|
|
||||||
}
|
|
||||||
defer file.Close()
|
|
||||||
|
|
||||||
encoder := json.NewEncoder(file)
|
|
||||||
if err := encoder.Encode(ctxRegMap); err != nil {
|
|
||||||
v.logErr(c, "devmode failed to persist ctx")
|
|
||||||
}
|
}
|
||||||
v.logDebug(c, "devmode persisted ctx to file")
|
v.logDebug(c, "devmode persisted ctx to file")
|
||||||
}
|
}
|
||||||
@@ -476,27 +479,11 @@ func (v *V) devModePersist(c *Context) {
|
|||||||
func (v *V) devModeRemovePersisted(c *Context) {
|
func (v *V) devModeRemovePersisted(c *Context) {
|
||||||
p := filepath.Join(".via", "devmode", "ctx.json")
|
p := filepath.Join(".via", "devmode", "ctx.json")
|
||||||
|
|
||||||
// load persisted list from file, or empty list if file not found
|
ctxRegMap := loadDevModeMap(p)
|
||||||
file, err := os.Open(p)
|
|
||||||
ctxRegMap := make(map[string]string)
|
|
||||||
if err == nil {
|
|
||||||
json.NewDecoder(file).Decode(&ctxRegMap)
|
|
||||||
}
|
|
||||||
file.Close()
|
|
||||||
|
|
||||||
delete(ctxRegMap, c.id)
|
delete(ctxRegMap, c.id)
|
||||||
|
|
||||||
// write persisted list to file
|
if err := saveDevModeMap(p, ctxRegMap); err != nil {
|
||||||
file, err = os.Create(p)
|
v.logErr(c, "devmode failed to remove persisted ctx: %v", err)
|
||||||
if err != nil {
|
|
||||||
v.logErr(c, "devmode failed to remove percisted ctx: %v", err)
|
|
||||||
|
|
||||||
}
|
|
||||||
defer file.Close()
|
|
||||||
|
|
||||||
encoder := json.NewEncoder(file)
|
|
||||||
if err := encoder.Encode(ctxRegMap); err != nil {
|
|
||||||
v.logErr(c, "devmode failed to remove persisted ctx")
|
|
||||||
}
|
}
|
||||||
v.logDebug(c, "devmode removed persisted ctx from file")
|
v.logDebug(c, "devmode removed persisted ctx from file")
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user