fix: nil-close bug, stale docs, dead code, and tracked binaries #7

ryan · 2026-02-20T20:00:00Z

ryan commented

2026-02-20 20:00:00 +00:00

Summary

Fix potential nil file.Close() panic in devMode functions by extracting loadDevModeMap/saveDevModeMap helpers with proper defer
Remove tracked binaries (pathparams 10.8 MB, shake.db 22 MB) and consolidate .gitignore with a wildcard pattern covering all 19 examples
Remove stale reaper reference in README, update example count from 14 to 19, fix OnChange debounce claim in docs
Fix typos: "percist"→"persist", "percisted"→"persisted", "tmplates"→"templates"
Remove dead code: commented imports, unnecessary fmt.Sprintf, no-op Config calls in examples
Replace go fmt with gofmt -l check in ci-check.sh to fail on unformatted code

Test plan

go build ./... passes
go vet ./... passes
go test ./... passes
./ci-check.sh passes (all 19 examples build)
gofmt -l . returns no output

## Summary - Fix potential nil `file.Close()` panic in devMode functions by extracting `loadDevModeMap`/`saveDevModeMap` helpers with proper defer - Remove tracked binaries (pathparams 10.8 MB, shake.db 22 MB) and consolidate `.gitignore` with a wildcard pattern covering all 19 examples - Remove stale reaper reference in README, update example count from 14 to 19, fix OnChange debounce claim in docs - Fix typos: "percist"→"persist", "percisted"→"persisted", "tmplates"→"templates" - Remove dead code: commented imports, unnecessary `fmt.Sprintf`, no-op Config calls in examples - Replace `go fmt` with `gofmt -l` check in ci-check.sh to fail on unformatted code ## Test plan - [x] `go build ./...` passes - [x] `go vet ./...` passes - [x] `go test ./...` passes - [x] `./ci-check.sh` passes (all 19 examples build) - [x] `gofmt -l .` returns no output

ryan added 1 commit 2026-02-20 20:00:01 +00:00

fix: nil-close bug, stale docs, dead code, and tracked binaries

CI / Build and Test (push) Successful in 38s

Details

CI / Build and Test (pull_request) Successful in 33s

Details

50e368f47b

- Fix potential nil file.Close() panic in devModePersist/devModeRemovePersisted
  by extracting loadDevModeMap/saveDevModeMap helpers with proper defer
- Remove tracked binaries (pathparams 10.8 MB, shake.db 22 MB) and consolidate
  .gitignore with a wildcard pattern covering all 19 examples
- Remove stale reaper reference in README (removed in dc56261), update example
  count from 14 to 19, fix OnChange debounce claim in docs
- Fix typos: "percist"→"persist", "percisted"→"persisted", "tmplates"→"templates"
- Remove dead code: commented import in signal_test.go, unnecessary fmt.Sprintf
  in computed.go, commented picocss imports and no-op Config calls in examples
- Replace go fmt with gofmt -l check in ci-check.sh to fail on unformatted code
  instead of silently reformatting

ryan merged commit cb13839157 into main

2026-02-20 20:00:44 +00:00

ryan referenced this issue from a commit

2026-02-20 20:00:45 +00:00

fix: nil-close bug, stale docs, dead code, and tracked binaries (#7)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: ryan/via#7