ryan/via
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 12 Wiki Activity

feat: complete Tier 4 marker/popup options, events, and live drag #16

Merged
ryan merged 1 commits from worktree-tier4-marker-popup into main 2026-02-21 00:38:28 +00:00
Conversation 0 Commits 1 Files Changed 4 +246 -21
ryan commented 2026-02-21 00:36:32 +00:00
Owner
Copy Link

Summary

  • Add missing marker options: offset, scale, opacity, opacityWhenCovered, className
  • Add missing popup options: closeOnClick, closeOnMove, anchor, offset, className
  • Return MarkerHandle from AddMarker with OnClick, OnDragStart, OnDrag, OnDragEnd
  • Return PopupHandle from ShowPopup with OnOpen, OnClose
  • Upgrade drag signal writeback to fire during drag (throttled via rAF) for real-time position sync

Partially addresses #1 (completes Tier 4).

## Summary - Add missing marker options: offset, scale, opacity, opacityWhenCovered, className - Add missing popup options: closeOnClick, closeOnMove, anchor, offset, className - Return `MarkerHandle` from `AddMarker` with `OnClick`, `OnDragStart`, `OnDrag`, `OnDragEnd` - Return `PopupHandle` from `ShowPopup` with `OnOpen`, `OnClose` - Upgrade drag signal writeback to fire during drag (throttled via rAF) for real-time position sync Partially addresses #1 (completes Tier 4).
ryan added 1 commit 2026-02-21 00:36:32 +00:00
feat: complete Tier 4 marker/popup options, events, and live drag (#1)
All checks were successful
CI / Build and Test (push) Successful in 38s
Details
CI / Build and Test (pull_request) Successful in 36s
Details
1d57a0962a 
Add missing marker options (offset, scale, opacity, opacityWhenCovered,
className) and popup options (closeOnClick, closeOnMove, anchor, offset,
className).

Return MarkerHandle from AddMarker with OnClick, OnDragStart, OnDrag,
OnDragEnd event methods. Return PopupHandle from ShowPopup with OnOpen,
OnClose event methods.

Upgrade drag signal writeback to fire during drag (throttled via
requestAnimationFrame) in addition to dragend, enabling real-time
position sync across clients.
ryan merged commit 453618f712 into main 2026-02-21 00:38:28 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ryan
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ryan/via#16
Delete Branch "worktree-tier4-marker-popup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?