feat: sync all markers across clients in MapLibre example (#9)

.claude/commands/pr.md

@@ -8,7 +8,7 @@ Create a PR on Gitea, wait for CI, and squash-merge it. Push code to both remote
 5. Create a Gitea PR: `tea pr create --head <branch> --base main`. Reference related issues with `#X`. Only use `Closes #X` if the PR fully resolves the issue.
 6. Wait for CI to pass: poll Gitea CI status. If CI fails, report the failure and stop — do not merge.
 7. Once CI passes, squash-merge on Gitea: `tea pr merge <index> --style squash` with a clean, semantic commit message including the PR number. No Claude attribution lines.
-8. Update local main and push to both remotes: `git checkout main && git pull gitea main && git push origin main`.
+8. Update local main and push to both remotes. If in a worktree, `main` is checked out in the primary tree, so run from there: `cd <primary-worktree> && git pull gitea main && git push origin main` (the primary worktree path is the repo root without `.claude/worktrees/…`). If not in a worktree: `git checkout main && git pull gitea main && git push origin main`.
 9. Clean up remote branches: `git push gitea --delete <branch> && git push origin --delete <branch>`.
 10. Prune refs: `git remote prune gitea && git remote prune origin`.
 11. Report the merged PR URL.

.gitignore

@@ -37,21 +37,15 @@ go.work.sum
 # Air artifacts
 *tmp/
 
-# binaries
-internal/examples/chatroom/chatroom
-internal/examples/counter/counter
-internal/examples/countercomp/countercomp
-internal/examples/greeter/greeter
-internal/examples/livereload/livereload
-internal/examples/picocss/picocss
-internal/examples/plugins/plugins
-internal/examples/realtimechart/realtimechart
-internal/examples/shakespeare/shakespeare
-internal/examples/nats-chatroom/nats-chatroom
-/nats-chatroom
+# Example binaries and data files
+internal/examples/*/[a-z]*[!.go]
+internal/examples/shakespeare/shake.db
 
 # NATS data directory
 data/
 
+# Standalone experiments
+nats-chatroom
+
 # Claude Code worktrees
 .claude/worktrees/

README.md

@@ -74,14 +74,13 @@ func main() {
 - **Plugin system** — `func(v *V)` hooks for integrating CSS/JS libraries
 - **Structured logging** — zerolog with configurable levels; console output in dev, JSON in production
 - **Graceful shutdown** — listens for SIGINT/SIGTERM, drains contexts, closes pub/sub
-- **Context lifecycle** — background reaper cleans up disconnected contexts; configurable TTL
 - **HTML DSL** — the `h` package provides type-safe Go-native HTML composition
 
 ## Examples
 
-The `internal/examples/` directory contains 14 runnable examples:
+The `internal/examples/` directory contains 19 runnable examples:
 
-`chatroom` · `counter` · `countercomp` · `greeter` · `keyboard` · `livereload` · `nats-chatroom` · `pathparams` · `picocss` · `plugins` · `pubsub-crud` · `realtimechart` · `session` · `shakespeare`
+`chatroom` · `counter` · `countercomp` · `effectspike` · `greeter` · `keyboard` · `livereload` · `maplibre` · `middleware` · `nats-chatroom` · `pathparams` · `picocss` · `plugins` · `pubsub-crud` · `realtimechart` · `session` · `shakespeare` · `signup` · `spa`
 
 ## Experimental
 

ci-check.sh

@@ -6,9 +6,13 @@ set -o pipefail
 ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 cd "$ROOT"
 
-echo "== CI: Format code =="
-go fmt ./...
-echo "OK: formatting complete"
+echo "== CI: Check formatting =="
+if [ -n "$(gofmt -l .)" ]; then
+  echo "ERROR: files not formatted:"
+  gofmt -l .
+  exit 1
+fi
+echo "OK: all files formatted"
 
 echo "== CI: Run go vet =="
 if ! go vet ./...; then

computed.go

@@ -1,7 +1,6 @@
 package via
 
 import (
-	"fmt"
 	"strconv"
 	"strings"
 
@@ -51,5 +50,5 @@ func (s *computedSignal) recompute() {
 }
 
 func (s *computedSignal) patchValue() string {
-	return fmt.Sprintf("%v", s.lastVal)
+	return s.lastVal
 }

docs/state-and-interactivity.md

@@ -94,7 +94,7 @@ Available triggers:
 |--------|-------|-------|
 | `OnClick()` | `click` | |
 | `OnDblClick()` | `dblclick` | |
-| `OnChange()` | `change` | 200ms debounce |
+| `OnChange()` | `change` | |
 | `OnInput()` | `input` | No debounce |
 | `OnSubmit()` | `submit` | |
 | `OnKeyDown(key)` | `keydown` | Filtered by key name (e.g. `"Enter"`, `"Escape"`) |

h/h.go

@@ -5,7 +5,7 @@
 //
 //	h.Div(
 //		h.H1(h.Text("Hello, Via")),
-//		h.P(h.Text("Pure Go. No tmplates.")),
+//		h.P(h.Text("Pure Go. No templates.")),
 //	)
 package h
 

internal/examples/livereload/main.go

@@ -2,7 +2,6 @@ package main
 
 import (
 	"github.com/ryanhamamura/via"
-	// "github.com/go-via/via-plugin-picocss/picocss"
 	"github.com/ryanhamamura/via/h"
 )
 
@@ -15,9 +14,6 @@ func main() {
 		DocumentTitle: "Live Reload Demo",
 		DevMode:       true,
 		LogLevel:      via.LogLevelDebug,
-		Plugins:       []via.Plugin{
-			// picocss.Default
-		},
 	})
 
 	v.Page("/", func(c *via.Context) {

internal/examples/maplibre/main.go

@@ -2,6 +2,8 @@ package main
 
 import (
 	"math/rand"
+	"strconv"
+	"sync"
 	"time"
 
 	"github.com/ryanhamamura/via"
@@ -9,6 +11,19 @@ import (
 	"github.com/ryanhamamura/via/maplibre"
 )
 
+type posMsg struct {
+	Lng float64 `json:"lng"`
+	Lat float64 `json:"lat"`
+}
+
+var (
+	vehicleOnce sync.Once
+	vehicle     struct {
+		mu       sync.RWMutex
+		lng, lat float64
+	}
+)
+
 func main() {
 	v := via.New()
 	v.Config(via.Options{
@@ -18,6 +33,21 @@ func main() {
 		Plugins:       []via.Plugin{maplibre.Plugin},
 	})
 
+	// Single goroutine moves the vehicle — all clients read the same position.
+	vehicle.lng = -122.43
+	vehicle.lat = 37.77
+	vehicleOnce.Do(func() {
+		go func() {
+			for {
+				time.Sleep(time.Second)
+				vehicle.mu.Lock()
+				vehicle.lng = -122.43 + (rand.Float64()-0.5)*0.02
+				vehicle.lat = 37.77 + (rand.Float64()-0.5)*0.02
+				vehicle.mu.Unlock()
+			}
+		}()
+	})
+
 	v.Page("/", func(c *via.Context) {
 		m := maplibre.New(c, maplibre.Options{
 			Style:  "https://demotiles.maplibre.org/style.json",
@@ -45,7 +75,7 @@ func main() {
 			},
 		})
 
-		// Signal-backed marker — server pushes position updates
+		// Purple vehicle marker — reads shared Go state
 		vehicleLng := c.Signal(-122.43)
 		vehicleLat := c.Signal(37.77)
 
@@ -56,12 +86,37 @@ func main() {
 		})
 
 		c.OnInterval(time.Second, func() {
-			vehicleLng.SetValue(-122.43 + (rand.Float64()-0.5)*0.02)
-			vehicleLat.SetValue(37.77 + (rand.Float64()-0.5)*0.02)
+			vehicle.mu.RLock()
+			lng, lat := vehicle.lng, vehicle.lat
+			vehicle.mu.RUnlock()
+			vehicleLng.SetValue(lng)
+			vehicleLat.SetValue(lat)
 			c.SyncSignals()
 		})
 
-		// Draggable marker — user drags, signals update
+		// Yellow click marker — synced across clients via PubSub
+		clickLng := c.Signal(-122.4194)
+		clickLat := c.Signal(37.7749)
+
+		m.AddMarker("clicked", maplibre.Marker{
+			LngSignal: clickLng,
+			LatSignal: clickLat,
+			Color:     "#f39c12",
+		})
+
+		via.Subscribe(c, "map.click", func(msg posMsg) {
+			clickLng.SetValue(msg.Lng)
+			clickLat.SetValue(msg.Lat)
+			c.SyncSignals()
+		})
+
+		click := m.OnClick()
+		handleClick := c.Action(func() {
+			e := click.Data()
+			via.Publish(c, "map.click", posMsg{Lng: e.LngLat.Lng, Lat: e.LngLat.Lat})
+		})
+
+		// Blue draggable pin — synced across clients via PubSub
 		pinLng := c.Signal(-122.41)
 		pinLat := c.Signal(37.78)
 
@@ -72,14 +127,16 @@ func main() {
 			Draggable: true,
 		})
 
-		// Click event — click to place a marker
-		click := m.OnClick()
-		handleClick := c.Action(func() {
-			e := click.Data()
-			m.AddMarker("clicked", maplibre.Marker{
-				LngLat: e.LngLat,
-				Color:  "#f39c12",
+		via.Subscribe(c, "map.pin", func(msg posMsg) {
+			pinLng.SetValue(msg.Lng)
+			pinLat.SetValue(msg.Lat)
+			c.SyncSignals()
 		})
+
+		handlePinDrag := c.Action(func() {
+			lng, _ := strconv.ParseFloat(pinLng.String(), 64)
+			lat, _ := strconv.ParseFloat(pinLat.String(), 64)
+			via.Publish(c, "map.pin", posMsg{Lng: lng, Lat: lat})
 		})
 
 		// GeoJSON polygon source + fill layer
@@ -111,7 +168,7 @@ func main() {
 			},
 		})
 
-		// FlyTo actions using CameraOptions
+		// FlyTo actions
 		zoom14 := 14.0
 		flyToSF := c.Action(func() {
 			m.FlyTo(maplibre.CameraOptions{
@@ -134,6 +191,7 @@ func main() {
 					h.H1(h.Text("MapLibre GL Example")),
 					m.Element(
 						click.Input(handleClick.OnInput()),
+						h.Input(h.Type("hidden"), pinLng.Bind(), handlePinDrag.OnInput()),
 					),
 					h.Div(h.Attr("style", "margin-top:1rem;display:flex;gap:0.5rem;flex-wrap:wrap"),
 						h.Button(h.Text("Fly to San Francisco"), flyToSF.OnClick()),
@@ -142,6 +200,7 @@ func main() {
 					h.Div(h.Attr("style", "margin-top:0.5rem;font-size:0.9rem"),
 						h.P(h.Text("Zoom: "), m.Zoom.Text()),
 						h.P(h.Text("Center: "), m.CenterLng.Text(), h.Text(", "), m.CenterLat.Text()),
+						h.P(h.Text("Click: "), clickLng.Text(), h.Text(", "), clickLat.Text()),
 						h.P(h.Text("Vehicle: "), vehicleLng.Text(), h.Text(", "), vehicleLat.Text()),
 						h.P(h.Text("Draggable Pin: "), pinLng.Text(), h.Text(", "), pinLat.Text()),
 					),

internal/examples/pathparams/main.go

@@ -4,17 +4,12 @@ import (
 	"strconv"
 
 	"github.com/ryanhamamura/via"
-	// "github.com/go-via/via-plugin-picocss/picocss"
 	. "github.com/ryanhamamura/via/h"
 )
 
 func main() {
 	v := via.New()
 
-	v.Config(via.Options{
-		// Plugins: []via.Plugin{picocss.Default},
-	})
-
 	v.Page("/counters/{counter_id}/{start_at_step}", func(c *via.Context) {
 
 		counterID := c.GetPathParam("counter_id")

internal/examples/picocss/main.go

@@ -2,7 +2,6 @@ package main
 
 import (
 	"github.com/ryanhamamura/via"
-	// "github.com/go-via/via-plugin-picocss/picocss"
 	"github.com/ryanhamamura/via/h"
 )
 
@@ -13,11 +12,6 @@ func main() {
 
 	v.Config(via.Options{
 		DocumentTitle: "Via Counter",
-		// Plugin is placed here. Use picocss.WithOptions(pococss.Options) to add the plugin
-		// with a different color theme or to enable a classes for a wide range of colors.
-		// Plugins: []via.Plugin{
-		// 	picocss.Default,
-		// },
 	})
 
 	v.Page("/", func(c *via.Context) {

internal/examples/realtimechart/main.go

@@ -6,7 +6,6 @@ import (
 	"time"
 
 	"github.com/ryanhamamura/via"
-	// "github.com/go-via/via-plugin-picocss/picocss"
 	"github.com/ryanhamamura/via/h"
 )
 
@@ -16,9 +15,6 @@ func main() {
 	v.Config(via.Options{
 		LogLevel: via.LogLevelDebug,
 		DevMode:  true,
-		Plugins: []via.Plugin{
-			// picocss.Default,
-		},
 	})
 
 	v.AppendToHead(

internal/examples/shakespeare/main.go

@@ -6,9 +6,9 @@ import (
 	"log"
 	"time"
 
+	_ "github.com/mattn/go-sqlite3"
 	"github.com/ryanhamamura/via"
 	"github.com/ryanhamamura/via/h"
-	_ "github.com/mattn/go-sqlite3"
 )
 
 type DataSource interface {
@@ -22,6 +22,9 @@ type ShakeDB struct {
 	findByTextStmt *sql.Stmt
 }
 
+// Prepare opens shake.db, a ~22 MB SQLite database of Shakespeare's works.
+// Download from https://github.com/nicholasgasior/gopher-fizzbuzz/raw/master/shake.db
+// and place it in this directory before running.
 func (shakeDB *ShakeDB) Prepare() {
 	db, err := sql.Open("sqlite3", "shake.db")
 	if err != nil {

signal.go

@@ -80,4 +80,3 @@ func (s *Signal) Int() int {
 	}
 	return 0
 }
-

signal_test.go

@@ -1,7 +1,6 @@
 package via
 
 import (
-	//	"net/http/httptest"
 	"testing"
 
 	"github.com/ryanhamamura/via/h"

via.go

@@ -439,36 +439,39 @@ func (v *V) ensureDatastarHandler() {
 	})
 }
 
+func loadDevModeMap(path string) map[string]string {
+	m := make(map[string]string)
+	file, err := os.Open(path)
+	if err != nil {
+		return m
+	}
+	defer file.Close()
+	json.NewDecoder(file).Decode(&m)
+	return m
+}
+
+func saveDevModeMap(path string, m map[string]string) error {
+	file, err := os.Create(path)
+	if err != nil {
+		return err
+	}
+	defer file.Close()
+	return json.NewEncoder(file).Encode(m)
+}
+
 func (v *V) devModePersist(c *Context) {
 	p := filepath.Join(".via", "devmode", "ctx.json")
 	if err := os.MkdirAll(filepath.Dir(p), 0755); err != nil {
 		v.logFatal("failed to create directory for devmode files: %v", err)
 	}
 
-	// load persisted list from file, or empty list if file not found
-	file, err := os.Open(p)
-	ctxRegMap := make(map[string]string)
-	if err == nil {
-		json.NewDecoder(file).Decode(&ctxRegMap)
-	}
-	file.Close()
-
-	// add ctx to persisted list
+	ctxRegMap := loadDevModeMap(p)
 	if _, ok := ctxRegMap[c.id]; !ok {
 		ctxRegMap[c.id] = c.route
 	}
 
-	// write persisted list to file
-	file, err = os.Create(p)
-	if err != nil {
-		v.logErr(c, "devmode failed to percist ctx: %v", err)
-
-	}
-	defer file.Close()
-
-	encoder := json.NewEncoder(file)
-	if err := encoder.Encode(ctxRegMap); err != nil {
-		v.logErr(c, "devmode failed to persist ctx")
+	if err := saveDevModeMap(p, ctxRegMap); err != nil {
+		v.logErr(c, "devmode failed to persist ctx: %v", err)
 	}
 	v.logDebug(c, "devmode persisted ctx to file")
 }
@@ -476,27 +479,11 @@ func (v *V) devModePersist(c *Context) {
 func (v *V) devModeRemovePersisted(c *Context) {
 	p := filepath.Join(".via", "devmode", "ctx.json")
 
-	// load persisted list from file, or empty list if file not found
-	file, err := os.Open(p)
-	ctxRegMap := make(map[string]string)
-	if err == nil {
-		json.NewDecoder(file).Decode(&ctxRegMap)
-	}
-	file.Close()
-
+	ctxRegMap := loadDevModeMap(p)
 	delete(ctxRegMap, c.id)
 
-	// write persisted list to file
-	file, err = os.Create(p)
-	if err != nil {
-		v.logErr(c, "devmode failed to remove percisted ctx: %v", err)
-
-	}
-	defer file.Close()
-
-	encoder := json.NewEncoder(file)
-	if err := encoder.Encode(ctxRegMap); err != nil {
-		v.logErr(c, "devmode failed to remove persisted ctx")
+	if err := saveDevModeMap(p, ctxRegMap); err != nil {
+		v.logErr(c, "devmode failed to remove persisted ctx: %v", err)
 	}
 	v.logDebug(c, "devmode removed persisted ctx from file")
 }