From 5967ca38051938dcee6bbb02413aa22e73bb97c0 Mon Sep 17 00:00:00 2001 From: ryan Date: Sat, 21 Feb 2026 02:51:40 +0000 Subject: [PATCH] fix: prevent marker snap-back during drag via PubSub echo (#18) --- maplibre/js.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/maplibre/js.go b/maplibre/js.go index 5077118..a2ce5ef 100644 --- a/maplibre/js.go +++ b/maplibre/js.go @@ -273,7 +273,7 @@ func markerBodyJS(mapID, markerID string, mk Marker) string { func dragHandlerJS(mapID string, mk Marker) string { // Shared writeback logic extracted into a local function for both handlers. return fmt.Sprintf( - `var _raf=0;`+ + `var _raf=0;mk._dragging=false;`+ `function _wb(){`+ `var pos=mk.getLngLat();`+ `var el=document.getElementById(%[1]s);if(!el)return;`+ @@ -284,8 +284,9 @@ func dragHandlerJS(mapID string, mk Marker) string { `if(sig===%[3]s){inp.value=pos.lat;inp.dispatchEvent(new Event('input',{bubbles:true}))}`+ `});`+ `}`+ + `mk.on('dragstart',function(){mk._dragging=true;});`+ `mk.on('drag',function(){if(_raf)return;_raf=requestAnimationFrame(function(){_raf=0;_wb()});});`+ - `mk.on('dragend',function(){cancelAnimationFrame(_raf);_raf=0;_wb()});`, + `mk.on('dragend',function(){cancelAnimationFrame(_raf);_raf=0;_wb();mk._dragging=false;});`, jsonStr("_vwrap_"+mapID), jsonStr(mk.LngSignal.ID()), jsonStr(mk.LatSignal.ID()), @@ -321,7 +322,7 @@ func markerEffectExpr(mapID, markerID string, mk Marker) string { } b.WriteString(fmt.Sprintf( `var m=window.__via_maps&&window.__via_maps[%s];`+ - `if(m&&m._via_markers[%[2]s]){`+ + `if(m&&m._via_markers[%[2]s]&&!m._via_markers[%[2]s]._dragging){`+ `m._via_markers[%[2]s].setLngLat([lng,lat])`, jsonStr(mapID), jsonStr(markerID))) if mk.RotationSignal != nil && mk.Element != "" {