fix: nil-close bug, stale docs, dead code, and tracked binaries
All checks were successful
CI / Build and Test (push) Successful in 38s
CI / Build and Test (pull_request) Successful in 33s

- Fix potential nil file.Close() panic in devModePersist/devModeRemovePersisted
  by extracting loadDevModeMap/saveDevModeMap helpers with proper defer
- Remove tracked binaries (pathparams 10.8 MB, shake.db 22 MB) and consolidate
  .gitignore with a wildcard pattern covering all 19 examples
- Remove stale reaper reference in README (removed in dc56261), update example
  count from 14 to 19, fix OnChange debounce claim in docs
- Fix typos: "percist"→"persist", "percisted"→"persisted", "tmplates"→"templates"
- Remove dead code: commented import in signal_test.go, unnecessary fmt.Sprintf
  in computed.go, commented picocss imports and no-op Config calls in examples
- Replace go fmt with gofmt -l check in ci-check.sh to fail on unformatted code
  instead of silently reformatting
This commit is contained in:
Ryan Hamamura
2026-02-20 09:58:46 -10:00
parent f833498b65
commit 50e368f47b
15 changed files with 44 additions and 81 deletions

View File

@@ -2,7 +2,6 @@ package main
import (
"github.com/ryanhamamura/via"
// "github.com/go-via/via-plugin-picocss/picocss"
"github.com/ryanhamamura/via/h"
)
@@ -15,9 +14,6 @@ func main() {
DocumentTitle: "Live Reload Demo",
DevMode: true,
LogLevel: via.LogLevelDebug,
Plugins: []via.Plugin{
// picocss.Default
},
})
v.Page("/", func(c *via.Context) {

View File

@@ -4,17 +4,12 @@ import (
"strconv"
"github.com/ryanhamamura/via"
// "github.com/go-via/via-plugin-picocss/picocss"
. "github.com/ryanhamamura/via/h"
)
func main() {
v := via.New()
v.Config(via.Options{
// Plugins: []via.Plugin{picocss.Default},
})
v.Page("/counters/{counter_id}/{start_at_step}", func(c *via.Context) {
counterID := c.GetPathParam("counter_id")

View File

@@ -2,7 +2,6 @@ package main
import (
"github.com/ryanhamamura/via"
// "github.com/go-via/via-plugin-picocss/picocss"
"github.com/ryanhamamura/via/h"
)
@@ -13,11 +12,6 @@ func main() {
v.Config(via.Options{
DocumentTitle: "Via Counter",
// Plugin is placed here. Use picocss.WithOptions(pococss.Options) to add the plugin
// with a different color theme or to enable a classes for a wide range of colors.
// Plugins: []via.Plugin{
// picocss.Default,
// },
})
v.Page("/", func(c *via.Context) {

View File

@@ -6,7 +6,6 @@ import (
"time"
"github.com/ryanhamamura/via"
// "github.com/go-via/via-plugin-picocss/picocss"
"github.com/ryanhamamura/via/h"
)
@@ -16,9 +15,6 @@ func main() {
v.Config(via.Options{
LogLevel: via.LogLevelDebug,
DevMode: true,
Plugins: []via.Plugin{
// picocss.Default,
},
})
v.AppendToHead(

View File

@@ -22,6 +22,9 @@ type ShakeDB struct {
findByTextStmt *sql.Stmt
}
// Prepare opens shake.db, a ~22 MB SQLite database of Shakespeare's works.
// Download from https://github.com/nicholasgasior/gopher-fizzbuzz/raw/master/shake.db
// and place it in this directory before running.
func (shakeDB *ShakeDB) Prepare() {
db, err := sql.Open("sqlite3", "shake.db")
if err != nil {