Fix connection indicator script duplication on SSE patches #12

Merged

ryan merged 1 commits from fix/connection-indicator-script into main 2026-03-03 20:44:57 +00:00

Conversation 0 Commits 1 Files Changed 1 +5 -1

ryan commented 2026-03-03 20:39:32 +00:00

Owner

Copy Link

Summary

• Split ConnectionIndicator into two components:
  • ConnectionIndicator(lastPing) - just the element, used for SSE patches
  • ConnectionIndicatorWithScript(lastPing) - element + script, used for initial page render
• Fixes issue where the setInterval script was re-added on every patch, creating multiple timers

## Summary - Split `ConnectionIndicator` into two components: - `ConnectionIndicator(lastPing)` - just the element, used for SSE patches - `ConnectionIndicatorWithScript(lastPing)` - element + script, used for initial page render - Fixes issue where the `setInterval` script was re-added on every patch, creating multiple timers

ryan added 1 commit 2026-03-03 20:39:32 +00:00

fix: separate connection indicator script from patchable element ... 0e344de9c1

The script was being re-added on every SSE patch, creating multiple
setInterval timers. Split into ConnectionIndicator (for patches) and
ConnectionIndicatorWithScript (for initial page render).

ryan force-pushed fix/connection-indicator-script from 0e344de9c1 to d6e64763cc 2026-03-03 20:44:03 +00:00 Compare

ryan merged commit f6c5949247 into main 2026-03-03 20:44:57 +00:00

ryan referenced this issue from a commit 2026-03-03 20:44:58 +00:00

Merge pull request 'Fix connection indicator script duplication on SSE patches' (#12) from fix/connection-indicator-script into main

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

ryan

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: ryan/games#12