refactor: extract shared player.ID type and GenerateID to player package

Both game and snake packages had identical PlayerID types and the snake
package imported game.GenerateID. Now both use player.ID and
player.GenerateID from the shared player package.

game/persist.go

@@ -4,6 +4,7 @@ import (
 	"context"
 
 	"github.com/ryanhamamura/c4/db/repository"
+	"github.com/ryanhamamura/c4/player"
 
 	"github.com/rs/zerolog/log"
 )
@@ -109,19 +110,19 @@ func gameFromRow(row *repository.Game) (*Game, error) {
 func playersFromRows(rows []*repository.GamePlayer) []*Player {
 	players := make([]*Player, 0, len(rows))
 	for _, row := range rows {
-		player := &Player{
+		p := &Player{
 			Nickname: row.Nickname,
 			Color:    int(row.Color),
 		}
 
 		if row.UserID != nil {
-			player.UserID = row.UserID
-			player.ID = PlayerID(*row.UserID)
+			p.UserID = row.UserID
+			p.ID = player.ID(*row.UserID)
 		} else if row.GuestPlayerID != nil {
-			player.ID = PlayerID(*row.GuestPlayerID)
+			p.ID = player.ID(*row.GuestPlayerID)
 		}
 
-		players = append(players, player)
+		players = append(players, p)
 	}
 	return players
 }

game/store.go

@@ -2,11 +2,10 @@ package game
 
 import (
 	"context"
-	"crypto/rand"
-	"encoding/hex"
 	"sync"
 
 	"github.com/ryanhamamura/c4/db/repository"
+	"github.com/ryanhamamura/c4/player"
 )
 
 type PlayerSession struct {
@@ -40,7 +39,7 @@ func (gs *GameStore) makeNotify(gameID string) func() {
 }
 
 func (gs *GameStore) Create() *GameInstance {
-	id := GenerateID(4)
+	id := player.GenerateID(4)
 	gi := NewGameInstance(id)
 	gi.queries = gs.queries
 	gi.notify = gs.makeNotify(id)
@@ -107,12 +106,6 @@ func (gs *GameStore) Delete(id string) error {
 	return nil
 }
 
-func GenerateID(size int) string {
-	b := make([]byte, size)
-	_, _ = rand.Read(b)
-	return hex.EncodeToString(b)
-}
-
 type GameInstance struct {
 	game    *Game
 	gameMu  sync.RWMutex
@@ -166,7 +159,7 @@ func (gi *GameInstance) GetGame() *Game {
 	return gi.game
 }
 
-func (gi *GameInstance) GetPlayerColor(pid PlayerID) int {
+func (gi *GameInstance) GetPlayerColor(pid player.ID) int {
 	gi.gameMu.RLock()
 	defer gi.gameMu.RUnlock()
 	for _, p := range gi.game.Players {

game/types.go

@@ -1,11 +1,13 @@
 package game
 
-import "encoding/json"
+import (
+	"encoding/json"
 
-type PlayerID string
+	"github.com/ryanhamamura/c4/player"
+)
 
 type Player struct {
-	ID       PlayerID
+	ID       player.ID
 	UserID   *string // UUID for authenticated users, nil for guests
 	Nickname string
 	Color    int // 1 = Red, 2 = Yellow